-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index pattern edit field formatter API #78352
Index pattern edit field formatter API #78352
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
…attern_edit_field_formatter
Split off field_mapping refactor changes into its own PR - #79918 - this PR will be a bit simpler once thats merged to master. |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…ime/kibana into index_pattern_edit_field_formatter
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
* Index pattern edit field formatter API # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpattern.md # docs/development/plugins/data/server/kibana-plugin-plugins-data-server.indexpattern.md # src/plugins/data/server/server.api.md
* master: (64 commits) Rename Security Solution Bug Template (elastic#81187) Update links (elastic#81125) Specify format for date range query (elastic#81025) [Alerting] Improve toast when alert is created (elastic#80327) [UX] Add empty states (elastic#80904) Add TS config for kibana_legacy (elastic#80992) [Telemetry] Add method to enable endpoint security data usage example (elastic#80940) [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794) Fix reactRouterNavigate when used with a string (elastic#80520) [Security Solution] [Detections] Read privileges for dependencies (elastic#80852) [ML] Fixing exclude frequent in advanced wizard (elastic#81121) Fix security solution template label (elastic#80976) [DOCS] Update index management docs (elastic#80893) [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814) skip flaky suite (elastic#81072) [Task Manager] Cleans up legacy plugin structure (elastic#80381) Support unsigned_long fields (elastic#81115) [Form lib] Export internal state instead of raw state (elastic#80842) [Lens] Add toast notification when visualization is saved (elastic#80788) Index pattern edit field formatter API (elastic#78352) ...
Summary
Adds methods for setting field formatters -
indexPattern.setFieldFormat
,indexPattern.deleteFieldFormat
Also adds
indexPattern.getFormatterForFieldNoDefault
- used by management interface.FieldFormatter instances aren't created until they're retrieved, instead of being created when the
IndexPattern
instance is initiated.Checklist
Delete any items that are not applicable to this PR.
Dev Docs
Adds methods for setting field formatters -
indexPattern.setFieldFormat
,indexPattern.deleteFieldFormat
Also addsindexPattern.getFormatterForFieldNoDefault
- used by management interface.